Find Duplicate Words In Two Files

I've two text files. I need to check for duplicate words inside them. Is there a way more concise than this code? file1 = set(line.strip() for line in open('/home/user1/file1.txt')

Solution 1:

You can write concise code but more importantly you don't need to create two sets, you can use set.intersection which will allow your code to work for larger data sets and run faster:

with open('/home/user1/file1.txt') as f1,  open('/home/user1/file2.txt') as f2:
    for line in set(map(str.rstrip,f2)).intersection(map(str.rstrip,f2))):
        print(line)

For python2 use itertools.imap:

from itertools import imap
with open('/home/user1/file1.txt') as f1,  open('/home/user1/file2.txt') as f2:
    for line in set(imap(str.rstrip,f2)).intersection(imap(str.rstrip(f2))):
        print(line)

You create a single set which is then added to iterating over the iterable passed in i.e the str.rstripped lines of file2 as oopposed to creating two full sets of lines first then doing the intersection.

Solution 2:

Even shorter:

with open('/home/user/file1.txt') as file1, open('/home/user/file2.txt') as file2:
    print "".join([word+"\n" for word in set(file1.read().split()) & set(file2.read().split())])

Solution 3:

This is one line shorter and closes both files after use:

with open('/home/user1/file1.txt') as file1, open('/home/user1/file2.txt') as file2:
    for line in set(line.strip() for line in file1) & set(line.strip() for line in file2):
        if line: 
            print(line)

Variation with only one set:

with open('/home/user1/file1.txt') as file1, open('/home/user1/file2.txt') as file2:
    for line in set(line.strip() for line in file1).intersection(line.strip() for line in 
                                                                 file2):
        if line: 
            print(line)